[improve][broker] PIP-429: Optimize Handling of Compacted Last Entry by Skipping Payload Buffer Parsing #24523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by Skipping Payload Buffer Parsing
github-actions
bot
added
the
doc
BewareMyPower
requested review from
RobertIndie,
codelipenghui,
coderzc,
dao-jun and
gaoran10
BewareMyPower
added
type/feature
coderzc
reviewed
Jul 28, 2025
pulsar-broker/src/main/java/org/apache/pulsar/compaction/TopicCompactionService.java
Show resolved
Hide resolved
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Aug 13, 2025
…by Skipping Payload Buffer Parsing (apache#24523)
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Aug 14, 2025
…by Skipping Payload Buffer Parsing (apache#24523)
KannarFr
pushed a commit
to CleverCloud/pulsar
that referenced
this pull request
Sep 22, 2025
…by Skipping Payload Buffer Parsing (apache#24523)
walkinggo
pushed a commit
to walkinggo/pulsar
that referenced
this pull request
Oct 8, 2025
…by Skipping Payload Buffer Parsing (apache#24523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #24439
Verifying this change
The functionality is covered by existing tests.
testGetLastMessageIdForEncryptedMessageis added to verify thatgetLastMessageIdstill works when encryption is enabled. It does not work without introducing thecompacted_batch_indexesfield toMessageMetadatabecause the broker side does not know how to deserialize theSingleMessageMetadata.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#43